This repository was archived by the owner on Dec 13, 2023. It is now read-only.
removed task ref name when processing event queue#3495
Merged
v1r3n merged 2 commits intoNetflix:mainfrom Mar 13, 2023
astelmashenko:feature/wait-complete-inside-loop
Merged
removed task ref name when processing event queue#3495v1r3n merged 2 commits intoNetflix:mainfrom astelmashenko:feature/wait-complete-inside-loop
v1r3n merged 2 commits intoNetflix:mainfrom
astelmashenko:feature/wait-complete-inside-loop
Conversation
Contributor
|
Hi @astelmashenko , Changes looks good. Can you please add a small unit test around this? Please check reference |
Contributor
Author
|
@manan164 , I quickly checked the reference test. DefaultEventQueueProcessor is wirtten a way it will require a lot of ceremony to setup a test. To make it easier to test DefaultEventQueueProcessor should be refactored e.g. into testable service with logic to process events and processor with code that subscribes to observable/etc. |
Contributor
|
Hi @astelmashenko , I think then we can go ahead with the current set of changes. |
Contributor
Author
|
@manan164 , why do not we merge this? |
v1r3n
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
Fixes #3494