This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Add in a default AWS credentials provider#3478
Merged
v1r3n merged 1 commit intoNetflix:mainfrom Mar 16, 2023
bjpirt:aws-credentials
Merged
Add in a default AWS credentials provider#3478v1r3n merged 1 commit intoNetflix:mainfrom bjpirt:aws-credentials
v1r3n merged 1 commit intoNetflix:mainfrom
bjpirt:aws-credentials
Conversation
v1r3n
approved these changes
Mar 13, 2023
Contributor
|
@bjpirt can you resolve the conflicts? |
Contributor
Author
|
@v1r3n Have resolved all of the conflicts now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
When using SQS it's necessary to add an AWS Credentials Provider to the queue configuration. It seemed sensible to do this by default since most people will need this and they can modify it if necessary. It also means that if you build the server from the community repository, which imports the exported packages from the conductor core, it will now work, whereas previously it failed to start the server, rendering SQS unusable from the community server.