This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Updated serverAndUI Dockerfile to set the correct startup script#3292
Merged
jxu-nflx merged 2 commits intoNetflix:mainfrom Oct 17, 2022
Merged
Updated serverAndUI Dockerfile to set the correct startup script#3292jxu-nflx merged 2 commits intoNetflix:mainfrom
jxu-nflx merged 2 commits intoNetflix:mainfrom
Conversation
Nginx was not running so the UI was not being served.
jxu-nflx
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the correct startup script so that the UI is served.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Updated the Dockerfile for the combined server and UI combined image.
Describe the new behavior from this PR, and why it's needed
The front end was not being served. The Dockerfile now uses the correct startup script.
Alternatives considered
Describe alternative implementation you have considered