This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Change TaskType to be string in order to define custom task and taskMappers#3154
Merged
apanicker-nflx merged 5 commits intoNetflix:mainfrom Oct 10, 2022
Merged
Change TaskType to be string in order to define custom task and taskMappers#3154apanicker-nflx merged 5 commits intoNetflix:mainfrom
apanicker-nflx merged 5 commits intoNetflix:mainfrom
Conversation
apanicker-nflx
approved these changes
Aug 8, 2022
Contributor
|
Just my 2 cents here, but loosening this type to a String doesn't seem quite like the correct thing to do here. Wonder if there's a better thing we can do to achieve your goal. @manan164 can you give everyone a more descriptive, in depth explanation of what you are trying to get by doing this? I can't quite tell by your comment above. |
Contributor
Author
|
Hi @james-deee , The motivation behind this PR is to make the conductor task more extensible. Consider a case where we are using a conductor jar and want to add a few system tasks. As of now, there is no way to do that since TaskType is an enum and that can't be extended. This PR enables that functionality. So to add a system task two things are needed (assuming PR merged),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
Using String task to enable custom tasks and taskMapper to be implemented in future.