This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Event handler for loop over task.#2883
Merged
apanicker-nflx merged 2 commits intoNetflix:mainfrom Mar 30, 2022
Merged
Conversation
manan164
commented
Mar 29, 2022
| .equals(taskRefName)) | ||
| .collect(Collectors.toList()); | ||
| if (!loopOverTaskList.isEmpty()) { | ||
| // Find loopover task with the highest iteration value |
Contributor
Author
There was a problem hiding this comment.
The assumption here is loop over task with the highest iteration only will be waiting for an event. Since older iteration gets completed.
apanicker-nflx
approved these changes
Mar 30, 2022
jxu-nflx
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Whenever the tasks are being retrieved for the event handler, the loop over tasks does not come since they are being appended by iteration value. This change enables performing an action on loop over task using an event handler.
Describe the new behavior from this PR, and why it's needed
Issue #2873