Skip to content

Refactor to provide protocols for all public structs#72

Merged
Nef10 merged 1 commit intomainfrom
refactor
Sep 22, 2021
Merged

Refactor to provide protocols for all public structs#72
Nef10 merged 1 commit intomainfrom
refactor

Conversation

@Nef10
Copy link
Owner

@Nef10 Nef10 commented Sep 22, 2021

This helps with mocking these types when testing software depending
on this library.

This helps with mocking these types when testing software depending
on this library.
@Nef10 Nef10 added feature New feature refactoring Code refactoring major This change should bump the major version of the next release labels Sep 22, 2021
@github-actions
Copy link

Coverage after merging refactor into main

1.89%

Coverage Report
FileStmtsFuncsLinesUncovered Lines
Sources/Wealthsimple
   Token.swift0%0%0%100–104, 111–124, 132–166, 168–191, 193–197, 199–205, 207–209, 211–219, 221–225, 47–52, 54–66, 68–79, 81–99
   TransactionError.swift0%0%0%29–46
   WealthsimpleAccount.swift0%0%0%100–112, 114–155, 80–95, 97–99
   WealthsimpleAsset.swift0%0%0%52–68
   WealthsimpleDownloader.swift0%0%0%104–117, 124–137, 139–151, 48–51, 55–80, 84–97
   WealthsimplePosition.swift0%0%0%100–117, 119–160, 53–57, 66–92, 94–99
   WealthsimpleTransaction.swift0%0%0%115–119, 138–182, 184–209, 211–252
Sources/Wealthsimple/Extensions
   String+CamelCase.swift100%100%100%

@Nef10 Nef10 merged commit 5502b33 into main Sep 22, 2021
@Nef10 Nef10 deleted the refactor branch September 22, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature major This change should bump the major version of the next release refactoring Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant