Add comprehensive test coverage for WealthsimpleTransaction#266
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive test coverage for the
WealthsimpleTransactionstruct, following the established patterns fromTokenTestsandWealthsimpleAccountTests. The implementation includes 34 test cases that thoroughly exercise all code paths in the transaction JSON parsing logic.Key Features
Complete JSON Parsing Coverage:
market_price,market_value, andnet_cashprocessDateandeffectiveDateComprehensive Error Handling:
Transaction Type Support:
buy,sell,dividend,custodianFeepaymentTransferInInfrastructure Improvements:
MockURLProtocolto support transaction request mockingTransactionError.Equatableconformance for robust test assertionsExample Test Coverage
The test suite ensures robust error handling for malformed API responses and validates that all transaction properties are correctly parsed from the Wealthsimple API JSON format.
Fixes #261.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.