Make URL base configurable with singleton URLConfiguration class#251
Merged
Make URL base configurable with singleton URLConfiguration class#251
Conversation
Co-authored-by: Nef10 <4551135+Nef10@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Make URL base configurable
Make URL base configurable with singleton URLConfiguration class
Aug 31, 2025
|
Minimum coverage required: 0%
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a configurable URL base system to enable easy redirection of all Wealthsimple API calls for testing purposes. Previously, all API endpoints used hardcoded URLs throughout the codebase, making it impossible to redirect calls to mock servers during unit testing.
Changes Made
New URLConfiguration Singleton Class
URLConfigurationsingleton that manages the base URL for all API endpointshttps://api.production.wealthsimple.com/v1/setBaseURL()method for testing configurationUpdated All API Classes
Token.swift: Replaced hardcoded URLs for/oauth/tokenand/oauth/token/infoWealthsimpleAccount.swift: Replaced hardcoded URL for/accountsWealthsimplePosition.swift: Replaced hardcoded URL for/positionsWealthsimpleTransaction.swift: Replaced hardcoded URL for/transactionsComprehensive Test Coverage
Usage for Testing
Benefits
Fixes #250.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.