Skip to content

Add return of capital transaction type#240

Merged
Nef10 merged 1 commit intomainfrom
type
Jun 3, 2025
Merged

Add return of capital transaction type#240
Nef10 merged 1 commit intomainfrom
type

Conversation

@Nef10
Copy link
Owner

@Nef10 Nef10 commented Jun 3, 2025

No description provided.

@Nef10 Nef10 added the enhancement Improvement to an existing feature label Jun 3, 2025
@Nef10 Nef10 requested a review from Copilot June 3, 2025 05:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new transaction type for "Return of Capital" and updates the way manufactured dividend raw values are defined. Key changes include:

  • Removal of explicit raw value assignment for manufacturedDividend.
  • Addition of a new enum case for returnOfCapital with an accompanying documentation comment.

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

Minimum coverage required: 0%


Coverage after merging type into main

1.88%

Coverage Report
FileStmtsFuncsLinesUncovered Lines
Sources/Wealthsimple
   Token.swift0%0%0%100–104, 111–124, 132–154, 156–167, 169–192, 194–198, 200–206, 208–210, 212–220, 222–226, 47–52, 54–66, 68–79, 81–99
   TransactionError.swift0%0%0%29–46
   WealthsimpleAccount.swift0%0%0%100–114, 116–139, 141–160, 82–97, 99
   WealthsimpleAsset.swift0%0%0%52–68
   WealthsimpleDownloader.swift0%0%0%102–115, 122–135, 137–149, 48–51, 55–78, 82–95
   WealthsimplePosition.swift0%0%0%100–117, 119–142, 144–163, 53–57, 66–92, 94–99
   WealthsimpleTransaction.swift0%0%0%127–131, 150–194, 196–221, 223–246, 248–267
Sources/Wealthsimple/Extensions
   String+CamelCase.swift100%100%100%

@Nef10 Nef10 merged commit 7dcea86 into main Jun 3, 2025
4 checks passed
@Nef10 Nef10 deleted the type branch June 3, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants