Make optional options optional in typings and add type tests#622
Merged
amitguptagwl merged 6 commits intoNaturalIntelligence:masterfrom Nov 22, 2023
Merged
Make optional options optional in typings and add type tests#622amitguptagwl merged 6 commits intoNaturalIntelligence:masterfrom
amitguptagwl merged 6 commits intoNaturalIntelligence:masterfrom
Conversation
Vulnerable Libraries (8)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
amitguptagwl
reviewed
Nov 5, 2023
Member
|
Hi @jdforsythe |
Contributor
Author
|
@amitguptagwl this has been fixed |
amitguptagwl
approved these changes
Nov 22, 2023
Member
|
Thanks for this change. I'll confirm and publish soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
See #612
This changes the type definitions to set all options with defaults to optional in the typings.
It adds documentation to all types so they show up in Intellisense when using the types.
It adds a type test - defining objects as the various options types (parse, validate, build) with none of the optional properties. Simply run
npm test-typesto attempt to compile the TS file and it will emit any type errors.Example with no errors:
Example with an error - add
someNewPropertyto the type definition as non-optional:fxp.d.ts:
The type test will now fail since the
typings-test.tsfile does not include this property in the validation options and it's listed as required:This will ensure the test fails if a property is added to the type as non-optional but not added to the
typings-test.tsfile as a required property.Type
Please mention the type of PR
Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend
[WIP]in PR title. Your PR will be reviewed when[WIP]will be removed from the PR title.Bookmark this repository for further updates.