Qt5 style fixes #915
Qt5 style fixes #915
Conversation
Fixes for Qt5 style regressions.
devernay
left a comment
There was a problem hiding this comment.
I prefer a cluttered stylesheet to cluttered code (and please add comments in both for things that are hacks, for the day we clean these up)
| ///filling tabs now | ||
|
|
||
| _aboutText = new QTextBrowser(_tabWidget); | ||
| _aboutText->setObjectName( QString::fromUtf8("TextBrowser") ); |
There was a problem hiding this comment.
what is the objectname in Qt5? Doesn't it make more sense to use that objectname in the stylesheet as an alternative, rather than cluttering (a tiny bit) the code?
There was a problem hiding this comment.
For some reason QTextBrowser defaults to black text in some widgets, but not all. So adding a objectname makes it easy to style the widgets that needs fixes.
Can of course figure out a better solution, just launched Natron and noticed the issue. Will close and submit a new PR when changed.
There was a problem hiding this comment.
There was a problem hiding this comment.
Agree to avoid code clutter, will find a qss-only fix.
Fixes for Qt5 style regressions.
Only tested on Ubuntu with Qt 5.15.3.
Screenshots
Natron 2.5.0 release (Qt4)
Natron RB-2.5 (Qt 5.15.3)
After pull request