Translate concept/collection types on concept page#1910
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1910 +/- ##
============================================
- Coverage 70.38% 70.32% -0.07%
Complexity 1658 1658
============================================
Files 34 34
Lines 4356 4364 +8
============================================
+ Hits 3066 3069 +3
- Misses 1290 1295 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miguelvaara
approved these changes
Jan 28, 2026
Contributor
miguelvaara
left a comment
There was a problem hiding this comment.
Everything looks correct and works well - great! From my side, it’s fine to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
Concept types were not localized (translated) on the concept page in all cases. This PR makes sure that also types that are localized via the translation files (e.g. skos:Collection, iso-thes:ConceptGroup) are properly translated. A Cypress test verifies this.
For example the display of the YSO group 00 General terms was affected by this.
Before this PR:
After:
Link to relevant issue(s), if any
Description of the changes in this PR
groupstest vocabulary URI space (needed by cypress test)Known problems or uncertainties in this PR
Some mapping-related Cypress tests are failing, but they are not related to this change and PR #1912 should fix them.
Checklist
.sr-onlyclass, color contrast)