Merged
Conversation
added 18 commits
December 30, 2025 15:06
added 9 commits
January 2, 2026 16:11
|
Member
|
Thanks again, very reasonable! Merging this now for the 3.1 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Reasons for creating this PR
Support base href and config path variables in the environment for better docker deployment (same as
SKOSMOS_SPARQL_ENDPOINT) .Link to relevant issue(s), if any
Description of the changes in this PR
SKOSMOS_CONFIG_PATHandSKOSMOS_BASE_HREF.src/model/GlobalConfig.phpso when no$config_nameis provided it will fallback to the env variable or the original../../config.ttlfor retro-compatibility.$config_namein the constructor ofsrc/model/Model.phpwhich was a duplicate ofGlobalConfig.php$config_nameandSKOSMOS_CONFIG_PATHto be either absolute (starts with/) or relative. This made me update some tests to remove the starting/in the config_name. (i.e./../../tests/testconfig.ttlturned into../../tests/testconfig.ttl)Known problems or uncertainties in this PR
Some config that had defined the
$config_namewith a starting/might need to update the config_name.Checklist
.sr-onlyclass, color contrast)