Skip to content

Fix vocab statistics styling#1853

Merged
UnniKohonen merged 2 commits intomainfrom
fix-vocab-statistics-styling
Dec 4, 2025
Merged

Fix vocab statistics styling#1853
UnniKohonen merged 2 commits intomainfrom
fix-vocab-statistics-styling

Conversation

@UnniKohonen
Copy link
Contributor

Reasons for creating this PR

Vocab statistics tables on vocab home page are not styled properly, this PR adds correct styles.

Link to relevant issue(s), if any

Description of the changes in this PR

  • Fix CSS selectors and rules for statistics
  • Separate vocab properties, statistics and download links to their own sections
  • Fix html in Vue components
  • Rename vocab-counts.js -> resource-counts.js to match the name of the vue component

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@UnniKohonen UnniKohonen added this to the 3.0 milestone Dec 4, 2025
@UnniKohonen UnniKohonen self-assigned this Dec 4, 2025
@UnniKohonen UnniKohonen requested a review from osma December 4, 2025 13:20
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, excellent!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

@UnniKohonen UnniKohonen merged commit b4097dd into main Dec 4, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this to Issue/PR closed in Skosmos 3.x Backlog Dec 4, 2025
@UnniKohonen UnniKohonen deleted the fix-vocab-statistics-styling branch December 4, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants