Skip to content

Search result autocomplete should have concept type labels#1851

Merged
joelit merged 7 commits intomainfrom
issue1794-search-result-concept-types
Dec 4, 2025
Merged

Search result autocomplete should have concept type labels#1851
joelit merged 7 commits intomainfrom
issue1794-search-result-concept-types

Conversation

@joelit
Copy link
Contributor

@joelit joelit commented Dec 4, 2025 •
edited
Loading

Reasons for creating this PR

Link to relevant issue(s), if any

Description of the changes in this PR

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@joelit joelit added this to the 3.0 milestone Dec 4, 2025
@joelit joelit self-assigned this Dec 4, 2025
@joelit joelit moved this to Needs review in Skosmos 3.x Backlog Dec 4, 2025
@joelit joelit force-pushed the issue1794-search-result-concept-types branch from 08d71f1 to 06c02d6 Compare December 4, 2025 08:50
@joelit joelit requested a review from osma December 4, 2025 09:05
UnniKohonen
UnniKohonen requested changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@UnniKohonen UnniKohonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The renderType function doesn't seem to be in use in global or vocab search Vue components. It should either be removed or used.

Not sure if it's in the scope of this PR but I noticed that searching for groups (e.g. "22 Maatalous" in YSO) does not show the type.

Otherwise, the PR looks good!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
20.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

UnniKohonen
UnniKohonen approved these changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@UnniKohonen UnniKohonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joelit joelit merged commit 47ca20f into main Dec 4, 2025
15 of 16 checks passed
@github-project-automation github-project-automation bot moved this from Needs review to Issue/PR closed in Skosmos 3.x Backlog Dec 4, 2025
@joelit joelit deleted the issue1794-search-result-concept-types branch December 4, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UnniKohonen UnniKohonen UnniKohonen approved these changes

@osma osma Awaiting requested review from osma

Assignees

@joelit joelit

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

3.6.1 Labels for search result types should be provided by the backend in the SKOSMOS object and displayed in search results

2 participants

@joelit @UnniKohonen