Skip to content

Update topbar navigation (inc. language links) during partial page load#1850

Merged
osma merged 1 commit intomainfrom
issue1848-fix-partial-page-load-ui-language
Dec 4, 2025
Merged

Update topbar navigation (inc. language links) during partial page load#1850
osma merged 1 commit intomainfrom
issue1848-fix-partial-page-load-ui-language

Conversation

@osma
Copy link
Member

@osma osma commented Dec 3, 2025

Reasons for creating this PR

Fix a bug where changing the UI language after a partial page load could load the wrong page, see #1848.

This PR adds one more step to the partial page load: updating the topbar navigation links by copying them from the loaded concept page into the current page DOM. I also added a Cypress E2E test to verify that it works.

Link to relevant issue(s), if any

Description of the changes in this PR

  • add updateTopbarNav function to partial-page-load.js
  • add Cypress test to verify

Known problems or uncertainties in this PR

None

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 3.0 milestone Dec 3, 2025
@osma osma self-assigned this Dec 3, 2025
@osma osma added the bug label Dec 3, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2025

@osma osma moved this to Needs review in Skosmos 3.x Backlog Dec 3, 2025
@osma osma requested a review from UnniKohonen December 4, 2025 08:20
Copy link
Contributor

@UnniKohonen UnniKohonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@osma osma merged commit 1753aa6 into main Dec 4, 2025
16 checks passed
@osma osma deleted the issue1848-fix-partial-page-load-ui-language branch December 4, 2025 08:39
@github-project-automation github-project-automation bot moved this from Needs review to Issue/PR closed in Skosmos 3.x Backlog Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing UI language after partial page load opens wrong page

2 participants