Update topbar navigation (inc. language links) during partial page load#1850
Merged
Update topbar navigation (inc. language links) during partial page load#1850
Conversation
…ad + add Cypress test to verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Reasons for creating this PR
Fix a bug where changing the UI language after a partial page load could load the wrong page, see #1848.
This PR adds one more step to the partial page load: updating the topbar navigation links by copying them from the loaded concept page into the current page DOM. I also added a Cypress E2E test to verify that it works.
Link to relevant issue(s), if any
Description of the changes in this PR
updateTopbarNavfunction to partial-page-load.jsKnown problems or uncertainties in this PR
None
Checklist
.sr-onlyclass, color contrast)