Skip to content

Fix sizing of sidebar Vue components#1849

Merged
UnniKohonen merged 1 commit intomainfrom
fix-sidebar-vue-components-sizing
Dec 3, 2025
Merged

Fix sizing of sidebar Vue components#1849
UnniKohonen merged 1 commit intomainfrom
fix-sidebar-vue-components-sizing

Conversation

@UnniKohonen
Copy link
Contributor

Reasons for creating this PR

Sidebar Vue components have incorrect initial height and width before load and often incorrect width after load. This PR fixes the component sizing.

Link to relevant issue(s), if any

Description of the changes in this PR

  • Fix setting sidebar width in alphabetical, hierarchical, groups and changes tabs
  • Fix setting initial sizing for sidebar in alphabetical and changes tabs

Addresses requirement 3k in #1521 and 1c in #1563

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@UnniKohonen UnniKohonen added this to the 3.0 milestone Dec 3, 2025
@UnniKohonen UnniKohonen self-assigned this Dec 3, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2025

@UnniKohonen UnniKohonen requested a review from osma December 3, 2025 12:22
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I couldn't see any problems in Firefox even before this fix, but Chromium is affected and this PR seems to improve the layout.

@UnniKohonen UnniKohonen merged commit 10ffc4c into main Dec 3, 2025
17 of 18 checks passed
@UnniKohonen UnniKohonen deleted the fix-sidebar-vue-components-sizing branch December 3, 2025 13:49
@github-project-automation github-project-automation bot moved this to Issue/PR closed in Skosmos 3.x Backlog Dec 3, 2025
@UnniKohonen UnniKohonen moved this from Issue/PR closed to Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR, update docs) in Skosmos 3.x Backlog Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants