Merged
Conversation
….logs, add checks for mounting vue components
osma
approved these changes
Nov 27, 2025
Member
osma
left a comment
There was a problem hiding this comment.
Looks good. I couldn't get any JS/Vue related messages to appear in the log anymore. Also the uiDevMode setting works as it should. Great work!
A couple of suggestions before merging:
- add the uiDevMode setting to
config.ttl.dist(with the default value false, or commented out) - document the uiDevMode setting on the wiki page Configuration for Skosmos 3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Reasons for creating this PR
There are many warnings originating from Vue and a lot of unnecessary output to console from JS code that could be removed.
Link to relevant issue(s), if any
Description of the changes in this PR
uiDevModefor loading either production or development version of VueKnown problems or uncertainties in this PR
Checklist
.sr-onlyclass, color contrast)