Skip to content

fix translations for 'Download this concept' heading on concept page#1836

Merged
osma merged 1 commit intomainfrom
issue1484-download-this-concept-translations
Nov 27, 2025
Merged

fix translations for 'Download this concept' heading on concept page#1836
osma merged 1 commit intomainfrom
issue1484-download-this-concept-translations

Conversation

@osma
Copy link
Member

@osma osma commented Nov 26, 2025

Reasons for creating this PR

The heading "Download this concept" on the concept page wasn't properly translated. There was a mismatch with the translation files, which used a different key "Download this concept in SKOS format:" that was used in Skosmos 2.

This PR clears up the message key mismatch and drops the obsolete messages. I've entered the old translations into Lokalise (adapted if necessary to omit the SKOS part and the trailing colon) and pulled them back in with bin/pull-translations.

Link to relevant issue(s), if any

Description of the changes in this PR

  • drop messages with the obsolete key "Download this concept in SKOS format:"
  • add translations for the new key "Download this concept" (pulled from Lokalise)

Known problems or uncertainties in this PR

none

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 3.0 milestone Nov 26, 2025
@osma osma self-assigned this Nov 26, 2025
@sonarqubecloud
Copy link

@osma osma moved this to Needs review in Skosmos 3.x Backlog Nov 26, 2025
@osma osma merged commit c3e4e66 into main Nov 27, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from Needs review to Issue/PR closed in Skosmos 3.x Backlog Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant