Skip to content

Fix hierarchy button visibility on concept pages#1833

Merged
UnniKohonen merged 2 commits intomainfrom
fix-hierarchy-button-visiblity-for-topconcept
Nov 25, 2025
Merged

Fix hierarchy button visibility on concept pages#1833
UnniKohonen merged 2 commits intomainfrom
fix-hierarchy-button-visiblity-for-topconcept

Conversation

@UnniKohonen
Copy link
Contributor

@UnniKohonen UnniKohonen commented Nov 25, 2025

Reasons for creating this PR

When visiting a concept page (e.g. https://test.dev.finto.fi/yso/en/page/p23406), opening the hierarchy in the sidebar creates a bug where the hierarchy button is not visible for the open top concept (e.g. objects).

Link to relevant issue(s), if any

Description of the changes in this PR

  • Set hasChildren property of the open top concept object correctly
  • Fix typos

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@UnniKohonen UnniKohonen added this to the 3.0 milestone Nov 25, 2025
@UnniKohonen UnniKohonen self-assigned this Nov 25, 2025
@UnniKohonen UnniKohonen moved this to Needs review in Skosmos 3.x Backlog Nov 25, 2025
@sonarqubecloud
Copy link

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I tested the fix using Firefox and Chromium on the given concept page.

I also tried a top concept without hierarchy (ysa: aakkoset) to make sure it doesn't show up wrong.

@UnniKohonen UnniKohonen merged commit 12e5803 into main Nov 25, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Needs review to Issue/PR closed in Skosmos 3.x Backlog Nov 25, 2025
@UnniKohonen UnniKohonen deleted the fix-hierarchy-button-visiblity-for-topconcept branch November 25, 2025 13:24
@UnniKohonen UnniKohonen moved this from Issue/PR closed to Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR, update docs) in Skosmos 3.x Backlog Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants