Fix hierarchy button visibility on concept pages#1833
Merged
UnniKohonen merged 2 commits intomainfrom Nov 25, 2025
Merged
Conversation
|
osma
approved these changes
Nov 25, 2025
Member
osma
left a comment
There was a problem hiding this comment.
LGTM.
I tested the fix using Firefox and Chromium on the given concept page.
I also tried a top concept without hierarchy (ysa: aakkoset) to make sure it doesn't show up wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Reasons for creating this PR
When visiting a concept page (e.g. https://test.dev.finto.fi/yso/en/page/p23406), opening the hierarchy in the sidebar creates a bug where the hierarchy button is not visible for the open top concept (e.g. objects).
Link to relevant issue(s), if any
Description of the changes in this PR
hasChildrenproperty of the open top concept object correctlyKnown problems or uncertainties in this PR
Checklist
.sr-onlyclass, color contrast)