Conversation
…edback page and vocab-home page
There was a problem hiding this comment.
Based on the changes made, the following have been reviewed in particular:
1
- Sidebar
- Search
- about
- feedback
2
The changes were compared visually with the layouts created by Hahmo (colors and sizes were not measured) and everything appears to be in order.
3
Frontend tests run – all OK
4
Accessibility tests run – all OK
The points that raised questions were the following:
1
The variables --sidebar-scrollbar-thumb and --vocab-bg do not have fallback colors defined, which could cause issues in older browsers that do not support CSS variables. We agreed together that we will not provide support for such old browsers. In practice all common browsers released after spring 2017 support this.
2
-.tooltip-html-content:after {
+.tooltip-html-content::after {
= Okay
3
A more detailed reviewing is not needed so based on a reasonably thorough review the work looks good - excellent! 👍
If you decide to fix the appearance issue (on the other comments) - great but if not, that is probably fine as well. In any case, I think this can be merged.
miguelvaara
left a comment
There was a problem hiding this comment.
You can merge it but please take a look at a couple of my suggestion. Nice work 👍
|
Reasons for creating this PR
Current Skosmos 3 CSS needs to refactored. The code is badly organized and there is a lot of unused and unnecessary code. This PR attempts to fix these issues.
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
Checklist
.sr-onlyclass, color contrast)