Skip to content

Upgrade PHP-CS-Fixer, add support for PHP 8.4#1830

Merged
osma merged 4 commits intomainfrom
php8.4-support
Nov 25, 2025
Merged

Upgrade PHP-CS-Fixer, add support for PHP 8.4#1830
osma merged 4 commits intomainfrom
php8.4-support

Conversation

@osma
Copy link
Member

@osma osma commented Nov 24, 2025

Reasons for creating this PR

Keep Skosmos up to date by supporting more recent PHP releases.

Link to relevant issue(s), if any

n/a

Description of the changes in this PR

  • Upgrade PHP-CS-Fixer to 3.90 (at least 3.80 is needed for PHP 8.4 support)
  • Update CI configuration to run PHPUnit tests under PHP 8.4 as well
  • Update list of supported PHP versions in README

Known problems or uncertainties in this PR

none

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 3.0 milestone Nov 24, 2025
@osma osma self-assigned this Nov 24, 2025
@osma osma added the maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance label Nov 24, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@osma osma moved this to Needs review in Skosmos 3.x Backlog Nov 25, 2025
@osma osma requested a review from joelit November 25, 2025 08:26
joelit
joelit approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@joelit joelit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests work fine, can be merged. However, the current tag in composer (v3.0-dev) is an old one, as it refers to a commit well in the past. It should be updated - proably with git tag -f v3.0-dev and that should be pushed upstream for all the tests to work in this PR.

@osma
Copy link
Member Author

osma commented Nov 25, 2025

The tag is indeed a problem, but it has already (around the time of the 3.0-beta.2 release) been recreated in GitHub so the problem should only appear in local git clones.

Merging this PR.

@osma osma merged commit 1f6dadc into main Nov 25, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from Needs review to Issue/PR closed in Skosmos 3.x Backlog Nov 25, 2025
@osma osma deleted the php8.4-support branch November 25, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelit joelit joelit approved these changes

Assignees

@osma osma

Labels

maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@osma @joelit