Skip to content

Fix width of changes tab on window resize#1826

Merged
UnniKohonen merged 1 commit intomainfrom
fix-changes-tab-width-on-window-resize
Nov 6, 2025
Merged

Fix width of changes tab on window resize#1826
UnniKohonen merged 1 commit intomainfrom
fix-changes-tab-width-on-window-resize

Conversation

@UnniKohonen
Copy link
Contributor

Reasons for creating this PR

Width of changes tab Vue component does not react to window resizing , this PR fixes that.

Link to relevant issue(s), if any

Description of the changes in this PR

  • Add event listener to changes tab component for window resizing

Addresses requirement 22 in #1735

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

@UnniKohonen UnniKohonen moved this to Needs review in Skosmos 3.x Backlog Nov 6, 2025
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem. Well done!

@UnniKohonen UnniKohonen added this to the 3.0-beta.2 milestone Nov 6, 2025
@UnniKohonen UnniKohonen merged commit b747d05 into main Nov 6, 2025
14 checks passed
@UnniKohonen UnniKohonen deleted the fix-changes-tab-width-on-window-resize branch November 6, 2025 10:48
@github-project-automation github-project-automation bot moved this from Needs review to Issue/PR closed in Skosmos 3.x Backlog Nov 6, 2025
@osma osma moved this from Issue/PR closed to Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR, update docs) in Skosmos 3.x Backlog Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants