Truncate long property value lists on concept page#1825
Merged
Conversation
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Reasons for creating this PR
Overwhelmingly long lists of property values on the concept page should be truncated, see #1795. This functionality exists in Skosmos 2, and this PR implements the same feature for Skosmos 3.
I looked at the jQuery-based implementation of this functionality in Skosmos 2 and adapted the same logic for Skosmos 3, but using vanilla JS instead. There is also a Cypress test that verifies that it works both in the initial page load and partial page load cases.
Example of the result (on the page http://localhost/Skosmos/ykl/fi/page/38.55 ):
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
skos:narrower. It does not truncate the "terms in other languages" section, unlike Skosmos 2, where also these were truncated. In Skosmos 3, the DOM structure of the "in other languages" section is very different than regular properties, so the same code doesn't work for both.Checklist
.sr-onlyclass, color contrast)