Show submembers of collections on concept page#1821
Merged
Conversation
|
miguelvaara
approved these changes
Nov 5, 2025
Contributor
miguelvaara
left a comment
There was a problem hiding this comment.
For testing purposes, checked the visuals also for the kieli ja kielet concept (http://www.yso.fi/onto/yso/p556). Works perfectly!
The code looks solid and also accessibility + UI and unit tests have all been run. The coding style was reviewed where applicable - everything is fine!
We can go for a merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
Implement display of collection (sub)members on the concept page, like this:
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
none
Checklist
.sr-onlyclass, color contrast)