Fix flaky vocab-home Cypress test under GitHub Actions CI#1819
Merged
Conversation
|
Member
Author
|
The Cypress tests have now passed 6 out of 6 times in CI. Merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Reasons for creating this PR
One of the vocab-home Cypress tests started failing very often (more than 50%) under GitHub Actions CI. It is a test that verifies that a partial page load is performed after clicking on the hierarchy. Part of the test checks that a mapping to Wikidata is shown properly. This fails, because the expected Wikidata label "fish" is not being shown.
I couldn't replicate the problem locally so I assume this has something to do with traffic between GitHub Actions and Wikidata. Maybe Wikidata blocks some queries?
This PR adjusts the test slightly so that either a label or Wikidata URI is an acceptable value. Now it should work under GitHub Actions as well.
Link to relevant issue(s), if any
n/a
Description of the changes in this PR
Known problems or uncertainties in this PR
It was a bit mysterious so not 100% sure this fixes the problem for good.
Checklist
.sr-onlyclass, color contrast)