Skip to content

Fix flaky vocab-home Cypress test under GitHub Actions CI#1819

Merged
osma merged 1 commit intomainfrom
fix-flaky-cypress-test-vocab-home
Oct 29, 2025
Merged

Fix flaky vocab-home Cypress test under GitHub Actions CI#1819
osma merged 1 commit intomainfrom
fix-flaky-cypress-test-vocab-home

Conversation

@osma
Copy link
Member

@osma osma commented Oct 29, 2025

Reasons for creating this PR

One of the vocab-home Cypress tests started failing very often (more than 50%) under GitHub Actions CI. It is a test that verifies that a partial page load is performed after clicking on the hierarchy. Part of the test checks that a mapping to Wikidata is shown properly. This fails, because the expected Wikidata label "fish" is not being shown.

I couldn't replicate the problem locally so I assume this has something to do with traffic between GitHub Actions and Wikidata. Maybe Wikidata blocks some queries?

This PR adjusts the test slightly so that either a label or Wikidata URI is an acceptable value. Now it should work under GitHub Actions as well.

Link to relevant issue(s), if any

n/a

Description of the changes in this PR

  • robustness fix: accept either wikidata label or URI in vocab-home cypress test

Known problems or uncertainties in this PR

It was a bit mysterious so not 100% sure this fixes the problem for good.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@sonarqubecloud
Copy link

@osma osma self-assigned this Oct 29, 2025
@osma osma added this to the 3.0-beta.2 milestone Oct 29, 2025
@osma osma added the maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance label Oct 29, 2025
@osma osma moved this to In progress in Skosmos 3.x Backlog Oct 29, 2025
@osma
Copy link
Member Author

osma commented Oct 29, 2025

The Cypress tests have now passed 6 out of 6 times in CI. Merging this.

@osma osma marked this pull request as ready for review October 29, 2025 14:41
@osma osma merged commit b837ad3 into main Oct 29, 2025
38 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Issue/PR closed in Skosmos 3.x Backlog Oct 29, 2025
@osma osma deleted the fix-flaky-cypress-test-vocab-home branch October 29, 2025 14:41
@osma osma moved this from Issue/PR closed to Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR, update docs) in Skosmos 3.x Backlog Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant