Skip to content

Fix sidebar gradient height#1807

Merged
UnniKohonen merged 1 commit intomainfrom
fix-sidebar-tab-gradient
Aug 28, 2025
Merged

Fix sidebar gradient height#1807
UnniKohonen merged 1 commit intomainfrom
fix-sidebar-tab-gradient

Conversation

@UnniKohonen
Copy link
Contributor

@UnniKohonen UnniKohonen commented Aug 28, 2025

Reasons for creating this PR

The height of the gradient applied to the last tab in the sidebar on narrow screens is not set correctly. This PR fixes it.

Link to relevant issue(s), if any

Description of the changes in this PR

Make the gradient height 100% of the parent nav-link element.

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@sonarqubecloud
Copy link

@UnniKohonen UnniKohonen merged commit 90b6734 into main Aug 28, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this to Issue/PR closed in Skosmos 3.x Backlog Aug 28, 2025
@UnniKohonen UnniKohonen deleted the fix-sidebar-tab-gradient branch August 28, 2025 10:40
@UnniKohonen UnniKohonen moved this from Issue/PR closed to Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR) in Skosmos 3.x Backlog Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant