Conversation
… to switch between h1/h2 depending on page type
|
The review is scheduled for the day before the last day of the ongoing psrint, right after the daily |
There was a problem hiding this comment.
Even though I cannot completely forget my earlier impressionss of Skosmos, I try to picture how the site and its pages would come across if someone described them to me just by using the heading levels (what kind of site it is and what the pages include).
A specialist at Celia once told me that a visually impaired person might not necessarily use a site in the "correct" way I described, but that over time assistive tools have shaped very personal habits and ways of navigating.
To avoid this mismatch I stick to my “eyes closed” experience while trusting that the chosen way of presenting the heading levels is valid and relevant. I focus on checking if the haedings work as they should.
Tip! I find HeadingsMap plugin very helpful.
Issue 1:
On http://localhost/skosmos/sv/about
there is a straight jump from level 2 to level 4.
@osma
Looks good in every way but I suggest fixing the above-mentioned issue before merging (it was the only issue I faced). After that, I think it can be merged.
|
Reasons for creating this PR
Fix many heading level issues in Skosmos 3, see #1801.
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
I'm not 100% sure that it's a great idea to make the "XX results for 'YYY'" message on search results pages into a h1 level heading. But there is no other obvious heading on the page, unless we want to add a prominent heading like "Search results" to the page.
I fixed a PHP crash on the error page within a vocabulary (e.g. http://localhost/Skosmos/yso/en/page/xxx ), but now the sidebar looks a bit strange, probably due to some CSS issues. Also, there should probably be a vocab header on this page:
Checklist
.sr-onlyclass, color contrast)