Skip to content

dockerfiles/README.md: updated curl command for loading voc to work with curl v8.5.0#1792

Merged
osma merged 3 commits intoNatLibFi:mainfrom
andrecastro0o:main
Oct 28, 2025
Merged

dockerfiles/README.md: updated curl command for loading voc to work with curl v8.5.0#1792
osma merged 3 commits intoNatLibFi:mainfrom
andrecastro0o:main

Conversation

@andrecastro0o
Copy link
Contributor

@andrecastro0o andrecastro0o commented Jun 16, 2025 •
edited
Loading

Reasons for creating this PR

Since my local machine is running curl v8.5.0 the vocabulary loading curl commands in dockerfiles/README.md were failing.

curl -I -X POST -H Content-Type:text/turtle -T unescothes.ttl -G http://localhost:9030/skosmos/data --data-urlencode graph=http://skos.um.es/unescothes/

Warning: You can only select one HTTP request method! You asked for both PUT
Warning: (-T, --upload-file) and HEAD (-I, --head).

I also saw that these changes to curl were tackled in #1695 but this readme seems to need updating

Description of the changes in this PR

Updates dockerfiles/README.md cURL commands to work with cURL v8.5.0

Known problems or uncertainties in this PR

Haven't been able to check whether changes are compatible with previous versions of cURL

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Jun 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.02%. Comparing base (7121d2d) to head (76a6221).
⚠️ Report is 96 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #1792   +/-   ##
=========================================
  Coverage     71.02%   71.02%           
  Complexity     1645     1645           
=========================================
  Files            33       33           
  Lines          4314     4314           
=========================================
  Hits           3064     3064           
  Misses         1250     1250

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@osma osma added the bug label Oct 28, 2025
@osma osma moved this to Current sprint backlog in Skosmos 3.x Backlog Oct 28, 2025
@osma osma moved this from Current sprint backlog to Needs review in Skosmos 3.x Backlog Oct 28, 2025
@osma osma self-assigned this Oct 28, 2025
@osma osma added this to the 3.0-beta.2 milestone Oct 28, 2025
osma
osma requested changes Oct 28, 2025
View reviewed changes
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and sorry for being so slow to process this.

I suggested skipping the URL encoding since it's not really necessary. Other than that, looks OK.

I will try to merge this very soon with the removed URL encoding.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 28, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@osma osma merged commit a04b671 into NatLibFi:main Oct 28, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Needs review to Issue/PR closed in Skosmos 3.x Backlog Oct 28, 2025
@osma osma changed the title updated curl for loading voc to work with curl v8.5.0 dockerfiles/REASME: updated curl command for loading voc to work with curl v8.5.0 Oct 28, 2025
@osma osma changed the title dockerfiles/REASME: updated curl command for loading voc to work with curl v8.5.0 dockerfiles/README.md: updated curl command for loading voc to work with curl v8.5.0 Oct 28, 2025
@osma osma moved this from Issue/PR closed to Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR, update docs) in Skosmos 3.x Backlog Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osma osma osma approved these changes

Assignees

@osma osma

Labels

bug

Projects

None yet

Milestone

3.0-beta.2

Development

Successfully merging this pull request may close these issues.

2 participants

@andrecastro0o @osma