Conversation
|
There was a problem hiding this comment.
Looks good, and it is definitely an improvement! I would align the logo to the main container using the bootstrap width breakpoints at 1400, 1200, 992, etc. so that the logo would get similar margins to the main container. Now the left-side margin of the logo is aligned to the topbar text.
However, this is down to individual taste. We could just iterate and ask for user feedback and resume tweaking the CSS on a later occasion - but then the issue needs to be documented.
The svg-logo started working by giving read permissions to it.
|
I suggest we merge this as is and then iterate later after wider review. It's a bit unclear what the requirements for the alignment and margins are. |



Reasons for creating this PR
The layout of the top header looks funny on very wide screens, because the contents (logo, navigation links etc.) are placed near the edges of the page.
This PR changes the header elements to use Bootstrap Grid classes (row, col) and then sets a max-width of 1460px for the contents. Also some margins and paddings are adjusted. The end result is that the navigation elements at the top are kept in the middle of the page, not near the edges.
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
I'm still not 100% happy with the alignment of the left and right edges. Especially on some zoom levels / page widths the edges don't always align nicely.
One problem here is that the Skosmos logo used within vocabularies (negative version, for use on a dark background) includes a lot of empty space around the logo itself within the svg file, making it hard to align. I tried two methods of cropping the svg to its content, but when I replaced the svg file with a cropped version, the logo just failed to display at all. I can't figure out why, but in any case, here are the two cropped logos (they look a bit funny here if you have a white background) in case they are useful:
Checklist
.sr-onlyclass, color contrast)