Narrower container for landing & other global page types#1787
Merged
Conversation
4afc132 to
f9565b5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Reasons for creating this PR
The landing page is too wide, it doesn't match the layout spec.
This PR adjusts the landing page and other global page types so that the container is a bit narrower on typical desktop browser window sizes. In practice, it reverts the landing page to the default Bootstrap 5 widths for
.containerwhile retaining the expanded 1460px width for the vocabulary-specific page types (vocab-home, concept, vocab-search).Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
Not sure if these widths are ideal, but at least it should be an improvement.
Checklist
.sr-onlyclass, color contrast)