Skip to content

Narrower container for landing & other global page types#1787

Merged
osma merged 1 commit intomainfrom
issue1480-landing-width
May 14, 2025
Merged

Narrower container for landing & other global page types#1787
osma merged 1 commit intomainfrom
issue1480-landing-width

Conversation

@osma
Copy link
Member

@osma osma commented May 13, 2025

Reasons for creating this PR

The landing page is too wide, it doesn't match the layout spec.

This PR adjusts the landing page and other global page types so that the container is a bit narrower on typical desktop browser window sizes. In practice, it reverts the landing page to the default Bootstrap 5 widths for .container while retaining the expanded 1460px width for the vocabulary-specific page types (vocab-home, concept, vocab-search).

Link to relevant issue(s), if any

Description of the changes in this PR

  • set max-width: 1460px only for vocabulary-specific page types instead of all of them

Known problems or uncertainties in this PR

Not sure if these widths are ideal, but at least it should be an improvement.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 3.0-alpha.2 milestone May 13, 2025
@osma osma self-assigned this May 13, 2025
@osma osma force-pushed the issue1480-landing-width branch from 4afc132 to f9565b5 Compare May 13, 2025 12:38
@sonarqubecloud
Copy link

@osma osma moved this to Needs review in Skosmos 3.x Backlog May 14, 2025
@osma osma requested a review from joelit May 14, 2025 07:55
Copy link
Contributor

@joelit joelit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osma osma merged commit b7fa55b into main May 14, 2025
10 checks passed
@osma osma deleted the issue1480-landing-width branch May 14, 2025 07:56
@github-project-automation github-project-automation bot moved this from Needs review to Issue/PR closed in Skosmos 3.x Backlog May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants