Visual layout improvements especially for landing page#1780
Merged
Conversation
UnniKohonen
reviewed
Mar 19, 2025
Contributor
UnniKohonen
left a comment
There was a problem hiding this comment.
This looks much better than it did before but there are some things I noticed that should still be fixed:
- The main sans-serif font is not set correctly
- To me the Skosmos logo looks a little big on the landing in comparison to the new sizing
- Vocab titles on vocab home page are no longer centered vertically
I also commented some minor code chages
src/view/landing.twig
Outdated
| <a class="fs-4 text-dark text-decoration-none" href="#">Skosmos is open source and on GitHub -></a> | ||
|
|
||
| <div class="bg-medium px-5 py-5 flex-grow-1 d-flex align-items-center" id="info-box"> | ||
| <a class="fs-5 text-dark text-decoration-none" href="#">Skosmos is open source and on GitHub -></a> |
Contributor
There was a problem hiding this comment.
A font awesome arrow icon could be added here.
|
Member
Author
|
Thanks for the comments @UnniKohonen! I think I've now implemented all the suggestions, except the horrible way of constructing links to vocabularies, which I think is a separate problem a bit out of scope for this PR, but we have issue #1565 to remind us about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
The landing page didn't follow the visual spec very well and there were issues with font sizes, with some users seeing absurdly large text. This PR attempts to fix the font size inconsistency issue by changing all font-size declarations to use
remunits. There are many visual improvements to the landing page layout as well as some adjustments that also affect other page types.Link to relevant issue(s), if any
Description of the changes in this PR
rem(except for the:rootelement, whereemis better)Known problems or uncertainties in this PR
Checklist
.sr-onlyclass, color contrast)