Implement infinite scrolling in new and deprecated view#1766
Implement infinite scrolling in new and deprecated view#1766UnniKohonen merged 4 commits intomainfrom
Conversation
|
joelit
left a comment
There was a problem hiding this comment.
I'd personally take some of the logging off at this point, but we can have a look at JS logging levels as a whole in a separate issue instead of tackling it here.
The feature works as intended, even in a mobile width single-column window - LGTM!
| this.currentOffset = 200 | ||
| // Add scrolling event listener back after changes are loaded | ||
| this.$refs.tabChanges.$refs.list.addEventListener('scroll', this.handleScrollEvent) | ||
| console.log('changes', this.changedConcepts) |
There was a problem hiding this comment.
Maybe we don't need the logging anymore at this point
| return data.json() | ||
| }) | ||
| .then(data => { | ||
| console.log('data', data) |
There was a problem hiding this comment.
Ditto. Maybe we don't need the logging anymore at this point.
| if (data.changeList.length > 0) { | ||
| this.$refs.tabChanges.$refs.list.addEventListener('scroll', this.handleScrollEvent) | ||
| } | ||
| console.log('changes', this.changedConcepts) |
There was a problem hiding this comment.
Ditto. Maybe we don't need the logging anymore at this point.
|
I created a separate issue about logging levels - #1773 |
Reasons for creating this PR
Changes view in sidebar does not currently load more concepts as the list is scrolled in Skosmos 3. This PR adds functionality to address this.
Link to relevant issue(s), if any
Description of the changes in this PR
Addresses requirement 7 in #1735
Known problems or uncertainties in this PR
Checklist
.sr-onlyclass, color contrast)