Implement basic functionality of groups view using Vue#1719
Implement basic functionality of groups view using Vue#1719UnniKohonen merged 8 commits intomainfrom
Conversation
There was a problem hiding this comment.
For consideration:
Would it look visually a bit more "pleasing/calm/harmonious" if the line breaks occurred slightly earlier, a few pixels further to the left before the gray vertical area?
Line breaks earlier before the gray area
Width 90%; does the trick here
Sidebar width (req 3.1 in #1704) is not currently set correctly so the line breaks don't look exactly right yet. This problem probably will come up again even after fixing the sizing, so I can fix it in this PR. |
|
miguelvaara
left a comment
There was a problem hiding this comment.
The code looks reasonable and its validation does not produce any errors. Additionally, all functionalities work flawlessly. Since this PR does not concern 6 Cypress tests (as the tests will be done later), I think everything works great. In my opinion, it can be merged and adjusting the line breaks can of course be done according to your own schedule.
Great job! 👍
Reasons for creating this PR
Groups view has not been implemented in the sidebar in Skosmos 3. This PR adds the groups view with basic functionality using Vue.
Link to relevant issue(s), if any
Description of the changes in this PR
Addresses requirement 1 ( + 2, 3.2, 3.3 and 3.5) in #1704
Known problems or uncertainties in this PR
Checklist
.sr-onlyclass, color contrast)