Skip to content

Fix deprecated concept pages (Skosmos 3)#1674

Merged
osma merged 4 commits intomainfrom
issue1635-fix-deprecated-bool
Aug 30, 2024
Merged

Fix deprecated concept pages (Skosmos 3)#1674
osma merged 4 commits intomainfrom
issue1635-fix-deprecated-bool

Conversation

@osma
Copy link
Member

@osma osma commented Aug 30, 2024

Reasons for creating this PR

This is a forward-port of PR #1673, made for Skosmos 2, to Skosmos 3. The only additional change is a minor adjustment to the PHPUnit test because getConceptInfo works a bit differently in Skosmos 3.

Link to relevant issue(s), if any

Description of the changes in this PR

See #1673

Known problems or uncertainties in this PR

Nope.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added the bug label Aug 30, 2024
@osma osma added this to the 3.0 milestone Aug 30, 2024
@osma osma self-assigned this Aug 30, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 30, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@osma
Copy link
Member Author

osma commented Aug 30, 2024

CI tests passed, merging this as this is essentially the same code that was already reviewed in PR #1673 .

@osma osma merged commit 5bbea00 into main Aug 30, 2024
@osma osma deleted the issue1635-fix-deprecated-bool branch August 30, 2024 13:04
@osma osma modified the milestones: 3.x, 3.0 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling removeDuplicatePropertyValues() on some elementary datatypes crashes Skosmos

1 participant