Upgrade EasyRdf to fix Turtle fragment URIs#1671
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## skosmos-2 #1671 +/- ##
===============================================
- Coverage 70.33% 69.65% -0.68%
- Complexity 1669 1784 +115
===============================================
Files 32 32
Lines 4305 4581 +276
===============================================
+ Hits 3028 3191 +163
- Misses 1277 1390 +113 ☔ View full report in Codecov by Sentry. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
We were using EasyRdf 1.7.x which is quite old and produces invalid Turtle fragment URIs in some cases, see #1591. The fix is to upgrade to easyrdf 1.10.x or newer. This PR upgrades to EasyRdf 1.13.x which is the most recent release that still works without breaking Skosmos 2 PHPUnit tests; EasyRdf 1.14.1 is currently the newest release. I don't think it makes sense to do extensive debugging of the failing Skosmos 2 unit tests, so I'm leaving the dependency at 1.13.x.
We need to drop support for PHP 7.x because EasyRdf 1.10 and above require at least PHP 8.0. This leaves only two supported PHP versions for Skosmos 2: PHP 8.0 and 8.1.
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
I didn't investigate closer why some PHPUnit tests fail when using easyrdf 1.14.x.
We need to do a similar EasyRdf upgrade for Skosmos 3 as well (main branch).
Checklist
.sr-onlyclass, color contrast)