The first version of translation functionality in Vue templates, whe…#1662
Closed
miguelvaara wants to merge 1 commit intoissue1527-translation-symfonyfrom
Closed
Conversation
…re translations are visible in the browser and the translation is read at the correct point in the code
|
Contributor
Author
|
The next step is to prepare this Draft PR for a design review. It is needed to briefly list what is intended to be demonstrated in the design review and where the focus of the future developement should be directed. For example, listing languages in the frontend code is unnecessary, as we can directly refer to Skosmos' runtime language, and there are also unnecessary empty spaces in the code ... among other things .. etc. |
Member
|
Should this PR be closed? I think it's been superseded by #1690 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…re translations are visible in the browser and the translation is read at the correct point in the code
Reasons for creating this PR
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
Checklist
.sr-onlyclass, color contrast)