SEO: vocab description, site name, type, canonical URL#1657
Merged
Conversation
|
joelit
approved these changes
Aug 21, 2024
Contributor
joelit
left a comment
There was a problem hiding this comment.
As far as I can understand, looks good to me!
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Reasons for creating this PR
This PR implements most of the remaining SEO functionality from #1533 :
In addition, there is a bug fix to the Request.getLangUrl method that broke when the Skosmos 3 code was restructured by moving backend code under
src/. This fix could have been a separate PR but since the bug was causing problems for the canonical URL generation, I decided to fix it here in this PR. The fix is in a separate commit 9bdb894 .Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
None so far!
Checklist
.sr-onlyclass, color contrast)