Conversation
|
Member
Author
|
Re-running Actions jobs twice, so that the Cypress tests have been run six times under CI in total. If they pass every time, I will merge this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
============================================
+ Coverage 70.62% 70.71% +0.08%
- Complexity 1645 1647 +2
============================================
Files 32 32
Lines 4320 4323 +3
============================================
+ Hits 3051 3057 +6
+ Misses 1269 1266 -3 ☔ View full report in Codecov by Sentry. |
Member
Author
|
All tests were successful, merging this. |
This was referenced Aug 20, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
Some Cypress runs were failing under GitHub Actions CI. In particular the "concept mappings / full" and/or "concept mappings / partial" tests for the concept page often failed. For example this run.
Adjusting the Cypress timeouts doesn't help, because the problem is that the underlying Skosmos resolver code (LinkedDataResolver) times out. The reason is that we've set a 2 second httpTimeout in testconfig.ttl, used to configure Skosmos for the PHPUnit and Cypress tests. This is too short to reliably resolve some of the mappings (LCSH, KOKO, YSA etc.) especially under the GitHub Actions CI environment.
The fix is simple: increase the timeout to 8 seconds. (Sidenote: this needs to be different from the default value of 5 seconds, because it is tested in a PHPUnit test that needs to verify that the non-default setting is effective. The test has been changed accordingly)
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
Not sure if 8 is the ideal value here but it's better than 2 for sure.
Checklist
.sr-onlyclass, color contrast)