SEO: descriptions on landing, about and feedback pages#1647
Merged
Conversation
757d205 to
c9dd489
Compare
|
Member
Author
|
Rebased on current |
miguelvaara
approved these changes
Aug 15, 2024
Contributor
miguelvaara
left a comment
There was a problem hiding this comment.
All tests (back-end & front-end) passed and the code and implementation look good. I think it can be merged, but maybe you could add descriptions to the Skosmos wiki? Good job!
Member
Author
|
I added wiki documentation to the checklist in the main SEO issue: #1533 (comment) Yes, obviously the documentation should explain that these configuration settings are related to SEO. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Reasons for creating this PR
This PR adds support for new SEO configuration options
skosmos:serviceDescription,skosmos:aboutDescriptionandskosmos:feedbackDescriptionwhich make it possible to set a description for the landing, about and feedback pages, respectively. The values are multilingual. If not set, there will be no description metadata on the respective page.Link to relevant issue(s), if any
Description of the changes in this PR
skosmos:serviceDescription,skosmos:aboutDescriptionandskosmos:feedbackDescriptionsettings in GlobalConfigKnown problems or uncertainties in this PR
There is no Cypress test for the case when one of the descriptions is not set in the configuration and thus should not be displayed. Should there be? The problem here is that this would require a separately configured Skosmos instance with a different configuration that omits some or all of the description settings. We currently only use one Skosmos instance for running Cypress tests, using the
tests/testconfig.ttlconfiguration file.Checklist
.sr-onlyclass, color contrast)