Skip to content

Make LOC HTTP prefLabel header parsing case-insensitive (Skosmos 3)#1620

Merged
osma merged 1 commit intomainfrom
issue1619-lcsh-label-lookup-skosmos3
Apr 16, 2024
Merged

Make LOC HTTP prefLabel header parsing case-insensitive (Skosmos 3)#1620
osma merged 1 commit intomainfrom
issue1619-lcsh-label-lookup-skosmos3

Conversation

@osma
Copy link
Member

@osma osma commented Apr 16, 2024

Reasons for creating this PR

Fix LCSH label lookups by making HTTP header parsing case-insensitive. See #1619

Link to relevant issue(s), if any

Description of the changes in this PR

Make LOC HTTP prefLabel header parsing case-insensitive in LOCResolver.php

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added the bug label Apr 16, 2024
@osma osma added this to the 3.0 milestone Apr 16, 2024
@osma osma self-assigned this Apr 16, 2024
@osma osma changed the title Make LOC HTTP prefLabel header parsing case-insensitive Make LOC HTTP prefLabel header parsing case-insensitive (Skosmos 3) Apr 16, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@osma osma merged commit b275ab8 into main Apr 16, 2024
@osma osma deleted the issue1619-lcsh-label-lookup-skosmos3 branch April 16, 2024 09:52
@osma osma modified the milestones: 3.x, 3.0 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label lookups for LCSH mappings are no longer working

1 participant