Fix diacritic letters in alphabetical index (Skosmos 3)#1580
Merged
Conversation
cfe7b83 to
bf68c52
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
=========================================
Coverage 70.54% 70.54%
Complexity 1644 1644
=========================================
Files 32 32
Lines 4315 4315
=========================================
Hits 3044 3044
Misses 1271 1271 ☔ View full report in Codecov by Sentry. |
joelit
approved these changes
Jan 24, 2024
Contributor
joelit
left a comment
There was a problem hiding this comment.
Looks good. The chosen filter seems like a right call - the diacritics in initial letters seem to work, and it does not break special characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
Fix the problem of diacritic letters (ÅÄÖ...) in Skosmos 3. It was already fixed for Skosmos 2 in PR #1575; this PR includes the fixes from that PR and also adds a Cypress test to verify it on the UI level.
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
n/a
Checklist
.sr-onlyclass, color contrast)