Skip to content

Avoid showing vocabulary modified timestamp on concept page when the concept doesn't have a specific modification date#1568

Merged
joelit merged 1 commit intomasterfrom
issue1343-concept-modified-timestamp
Dec 5, 2023
Merged

Avoid showing vocabulary modified timestamp on concept page when the concept doesn't have a specific modification date#1568
joelit merged 1 commit intomasterfrom
issue1343-concept-modified-timestamp

Conversation

@osma
Copy link
Member

@osma osma commented Dec 5, 2023

Reasons for creating this PR

See #1343

Link to relevant issue(s), if any

Description of the changes in this PR

  • introduce a new method Concept.getConceptModifiedDate that only returns the specific modification date of the concept but doesn't fall back to the vocabulary-level modified timestamp
  • use getConceptModifiedDate when showing modified timestamps on the concept page
  • unit test to verify

Known problems or uncertainties in this PR

Some unit tests will fail with deprecation warnings on PHP 8.1 for unrelated reasons - see PR #1567 for the explanation and fix.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma
avoid showing vocabulary modified timestamp on concept page when the …
9c085eb 
…concept doesn't have a specific modification date
@osma osma added the bug label Dec 5, 2023
@osma osma added this to the 2.17 milestone Dec 5, 2023
@osma osma self-assigned this Dec 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b9489a) 70.22% compared to head (9c085eb) 70.23%.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1568      +/-   ##
============================================
+ Coverage     70.22%   70.23%   +0.01%     
- Complexity     1665     1667       +2     
============================================
  Files            32       32              
  Lines          4295     4300       +5     
============================================
+ Hits           3016     3020       +4     
- Misses         1279     1280       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joelit
joelit reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@joelit joelit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works in my environment

@joelit joelit merged commit aab3aab into master Dec 5, 2023
@joelit joelit deleted the issue1343-concept-modified-timestamp branch December 5, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelit joelit joelit left review comments

Assignees

@osma osma

Labels

bug

Projects

None yet

Milestone

2.17

Development

Successfully merging this pull request may close these issues.

Skosmos shouldn't show the modified timestamp for a concept page unless such is explicitly stated for the concept data

2 participants

@osma @joelit