Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## skosmos-3 #1520 +/- ##
============================================
Coverage 70.51% 70.51%
Complexity 1642 1642
============================================
Files 32 32
Lines 4314 4314
============================================
Hits 3042 3042
Misses 1272 1272 ☔ View full report in Codecov by Sentry. |
osma
requested changes
Sep 21, 2023
Member
osma
left a comment
There was a problem hiding this comment.
Looks OK, except that the concept page is currently broken. Viewing http://localhost/Skosmos/yso/en/page/p12345 I get this error in the logs:
PHP Fatal error: Uncaught Twig\\Error\\SyntaxError: A message inside a trans tag must be a simple text. in /var/www/html/Skosmos/src/view/concept-card.inc:186
The solution is to use %term% instead of {{ term }} in the template (see comment)
Other than this, LGTM!
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
New Symfony translation component added to skosmos-3 branch. Translation tags/filters notation has changed from previously used.
Link to relevant issue(s), if any
Description of the changes in this PR
trans filters added to Twig templates and inc files. Translation files containing variables in their identifiers are translated with notation
{% trans %} ... %variable% ... {% endtrans %}Known problems or uncertainties in this PR
I could not find what causes and how to test this error message in file concept-card.inc:
{% trans %}Error: Term "{{ term }}" not found in vocabulary!{% endtrans %}Checklist
.sr-onlyclass, color contrast)