fix 'Any language' choice in language selection menu#1315
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #1315 +/- ##
=========================================
Coverage 70.36% 70.36%
Complexity 1649 1649
=========================================
Files 32 32
Lines 3790 3790
=========================================
Hits 2667 2667
Misses 1123 1123 Continue to review full report at Codecov.
|
kinow
approved these changes
Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
The "Any language" option in the content language selector was not working properly, probably because of changes caused by the Bootstrap 5 upgrade (#1182). When the user selected "Any language", the text changed to "undefined". This PR restores the original functionality.
Link to relevant issue(s), if any
Description of the changes in this PR
id="lang-button-all"instead ofclass="lang-button-all"because Bootstrap 5 seems to overwrite the class attribute but theidis preservedKnown problems or uncertainties in this PR
n/a
Checklist