Skip to content

Fix font color and size after Bootstrap 5 upgrade#1304

Merged
osma merged 1 commit intomasterfrom
issue1303-bootstrap-5-css-fixes
Apr 26, 2022
Merged

Fix font color and size after Bootstrap 5 upgrade#1304
osma merged 1 commit intomasterfrom
issue1303-bootstrap-5-css-fixes

Conversation

@osma
Copy link
Member

@osma osma commented Apr 26, 2022

Reasons for creating this PR

Fix minor CSS issues found after the Bootstrap upgrade (#1182)

Link to relevant issue(s), if any

Description of the changes in this PR

  • set the font size on the buttons next to the search box back to 14px
  • remove the CSS block that changed the color of text typed into the search box

Known problems or uncertainties in this PR

Hoping this won't have any adverse effects on other parts of the UI...

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added the bug label Apr 26, 2022
@osma osma added this to the 2.15 milestone Apr 26, 2022
@osma osma requested a review from kinow April 26, 2022 08:08
@codecov
Copy link

codecov bot commented Apr 26, 2022 •
edited
Loading

Codecov Report

Merging #1304 (5570d15) into master (dd94d44) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1304   +/-   ##
=========================================
  Coverage     69.44%   69.44%           
  Complexity     1657     1657           
=========================================
  Files            32       32           
  Lines          4068     4068           
=========================================
  Hits           2825     2825           
  Misses         1243     1243

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd94d44...5570d15. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@osma osma self-assigned this Apr 26, 2022
kinow
kinow approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kinow
Copy link
Collaborator

kinow commented Apr 26, 2022

Hoping this won't have any adverse effects on other parts of the UI...

Hopefully not! 🤞 Thanks @osma!

@osma osma merged commit 9b3aa64 into master Apr 26, 2022
@osma osma deleted the issue1303-bootstrap-5-css-fixes branch March 20, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kinow kinow kinow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@osma osma

Labels

bug

Projects

None yet

Milestone

2.15

Development

Successfully merging this pull request may close these issues.

Autocomplete problems after Bootstrap 5 upgrade

2 participants

@osma @kinow