Skip to content

drop useless SKOSMOS_VERSION build arg from Dockerfile#1293

Merged
osma merged 1 commit intomasterfrom
fix-dockerfile-version
Mar 28, 2022
Merged

drop useless SKOSMOS_VERSION build arg from Dockerfile#1293
osma merged 1 commit intomasterfrom
fix-dockerfile-version

Conversation

@osma
Copy link
Member

@osma osma commented Mar 25, 2022 •
edited
Loading

Reasons for creating this PR

I noticed that the Dockerfile for Skosmos declares a build argument SKOSMOS_VERSION which isn't actually used and the default value v.2.9 refers to an old version of Skosmos. This PR simply removes it.

Link to relevant issue(s), if any

n/a

Description of the changes in this PR

Drop the line with the SKOSMOS_VERSION declaration in Dockerfile

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added the bug label Mar 25, 2022
@osma osma added this to the 2.15 milestone Mar 25, 2022
@codecov
Copy link

codecov bot commented Mar 25, 2022 •
edited
Loading

Codecov Report

Merging #1293 (ce05e06) into master (ffc1d62) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1293   +/-   ##
=========================================
  Coverage     69.44%   69.44%           
  Complexity     1657     1657           
=========================================
  Files            32       32           
  Lines          4068     4068           
=========================================
  Hits           2825     2825           
  Misses         1243     1243

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffc1d62...ce05e06. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kinow
kinow approved these changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was used at some stage, to fetch a version of Skosmos to build, but shouldn't be used any longer.

CI errors appear to be unrelated. +1 Thanks!

@osma osma merged commit 442d792 into master Mar 28, 2022
@osma osma deleted the fix-dockerfile-version branch March 28, 2022 06:58
@osma osma self-assigned this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kinow kinow kinow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@osma osma

Labels

bug

Projects

None yet

Milestone

2.15

Development

Successfully merging this pull request may close these issues.

2 participants

@osma @kinow