Modify code to always have an ld json element, may be empty#1188
Merged
kouralex merged 1 commit intoNatLibFi:masterfrom Aug 23, 2021
Merged
Modify code to always have an ld json element, may be empty#1188kouralex merged 1 commit intoNatLibFi:masterfrom
kouralex merged 1 commit intoNatLibFi:masterfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this issue happens due to a mix of Twig and JS code. When you visit a vocabulary, the value of
request.page == 'page'is false, sincerequest.pagehas the value "vocab".But if you click on a concept, it will trigger the code to load concept mappings without changing the value of
request.page. That code won't find the JSON-LD script element, and result in a JS error. If you reload the page, now therequest.pagewill bepageand now the concept mappings will be displayed correctly.This pull request simply modifies the template to always have a JSON-LD script element, that may be empty (
{}). This way the code should work no matter what page is trying to load concept mappings. Tested locally with YSO vocabulary.Closes #1016