Suppress duplicate log messages from subject module#673
Merged
juhoinkinen merged 3 commits intomasterfrom Feb 13, 2023
Merged
Conversation
Codecov ReportBase: 99.56% // Head: 99.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 87 87
Lines 6145 6158 +13
=======================================
+ Hits 6118 6131 +13
Misses 27 27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
osma
approved these changes
Feb 10, 2023
Member
osma
left a comment
There was a problem hiding this comment.
Looks good, only a minor suggestion for the variable name
|
SonarCloud Quality Gate failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a project's vocabulary is not up-to-date with the corpus being used there can be very many warnings like
warning: Unknown subject URI <http://www.yso.fi/onto/yso/p22036>that flood the screen.See an example output
However, usually there are not so many URIs (or labels) that are absent from the vocabulary, but the message is shown for every occasion any of them is encounted in the corpus: the same warnings are duplicated many times. This PR suppresses the duplicate log messages that are raised from the subject.py module.
See the above output with this PR applied
Based on a SO answer.