Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 99.54% // Head: 99.55% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #650 +/- ##
=======================================
Coverage 99.54% 99.55%
=======================================
Files 87 87
Lines 5988 6004 +16
=======================================
+ Hits 5961 5977 +16
Misses 27 27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Looks very good!
I think that sounds like a good idea! Would it make sense to do this change already in this PR, or a new one after this has been merged? |
Better to make a new PR for that think, it might need some experimenting to make it work... |
osma
left a comment
There was a problem hiding this comment.
I tested this locally on my laptop. Works fine, although running poetry lock and poetry install --all-extras didn't remove pytest-flake8 so I removed it manually using pip.
But as the pytest option --flake8 was removed in this PR, it won't be used by pytest anyway, so even if the package remains installed it shouldn't do any harm.
Closes #599.
Unpins flake8. On my laptop version 5.0.4 get installed, while 6.0.0 was released two days ago.
In the CI/CD pipeline I added flake8 step that both installs flake8 from PyPI with pip and runs it. There version 6.0.0 get installed. I did not find a good GH Action for flake8 (an official one or any which seemed otherwise reputable), so it can be better to install it this way.
The mismatch of the versions is unfortunate, but makes no difference at this time.
Also I'm thinking that it might be a good idea to switch installing also isort and Black from PyPI (instead of using the GH Actions), and using Poetry for that (regular dependencies can be omitted by
poetry install --only dev).